feat(android-nav3): [Android Nav3 2] Model navigation routes - #6130
Open
0xadam-brown wants to merge 1 commit into
Open
0xadam-brown wants to merge 1 commit into
0xadam-brown wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
0xadam-brown
requested review from
adinauer,
markushi,
romtsn and
runningcode
as code owners
September 18, 2026 10:28
Copy link
Copy Markdown
Contributor
|
Sorry, something went wrong.
This was referenced Sep 18, 2026
Copy link
Copy Markdown
📲 Install BuildsAndroid
|
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 061c4c3. Configure here.
Sorry, something went wrong.
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-1-module
branch
from
e5d13ee to
1b98b50
Compare
September 18, 2026 11:28
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-2-routes
branch
from
7ea1f4c to
dc5546c
Compare
September 18, 2026 11:28
Introduce the route translation layer for Navigation 3 so later stages can reason about route names and sanitized arguments in one place. At this stage the module still exposes no meaningful public API surface.
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-2-routes
branch
from
dc5546c to
b0eb957
Compare
September 18, 2026 12:38
0xadam-brown
commented
Sep 18, 2026
Comment thread
sentry-android-navigation3/src/main/kotlin/io/sentry/compose/navigation3/RouteExtractors.kt
| * Doing so prevents route names from being obfuscated while leaving per-route arguments to | ||
| * [RouteArgumentsExtractor]. | ||
| */ | ||
| @ApiStatus.Experimental |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Marked as experimental b/c this will be made public in a follow-on to the current PR stack. (Same below.)
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Android Nav3)
📜 Description
To support Nav3 we have to map a host app's back stack to an internal representation suitable for the Sentry data we emit. This PR introduces the core logic for doing so in the form of a RouteTranslator.
Note that the RouteResolvers passed to the translators constructor are defined by the host app, and so we're careful to protect against misuse / unintended performance issues.
💡 Motivation and Context
addresses: JAVA-274
💚 How did you test it?
📝 Checklist
🔮 Next steps
Build the observer layer that consumes these routes and updates Sentry state.
#skip-changelog