feat(android-nav3): [Android Nav3 4] Introduce SentryNavEffect - #6132
Open
0xadam-brown wants to merge 2 commits into
Open
0xadam-brown wants to merge 2 commits into
0xadam-brown wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
0xadam-brown
requested review from
adinauer,
markushi,
romtsn and
runningcode
as code owners
September 18, 2026 10:28
This was referenced Sep 18, 2026
Copy link
Copy Markdown
Contributor
|
Sorry, something went wrong.
This was referenced Sep 18, 2026
Copy link
Copy Markdown
📲 Install BuildsAndroid
|
Sorry, something went wrong.
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-3-observer
branch
from
729cbc7 to
a0704f7
Compare
September 18, 2026 11:00
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-4-effect
branch
from
0111382 to
f841761
Compare
September 18, 2026 11:00
Copy link
Copy Markdown
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f841761. Configure here.
Sorry, something went wrong.
Comment thread
sentry-android-navigation3/build.gradle.kts
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-3-observer
branch
from
a0704f7 to
6a2c118
Compare
September 18, 2026 11:28
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-4-effect
branch
2 times, most recently
from
20d0b21 to
e1498fd
Compare
September 18, 2026 12:22
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-3-observer
branch
from
9e615c3 to
7e1db9e
Compare
September 18, 2026 12:38
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-4-effect
branch
from
e1498fd to
cffd83e
Compare
September 18, 2026 12:38
Comment thread
sentry-android-navigation3/src/test/kotlin/io/sentry/compose/navigation3/SentryNavEffectTest.kt
Outdated
Add the Compose-facing abstraction that binds Navigation 3 back stack changes to the observer layer. This establishes the integration’s primary API shape while keeping it internal until the rest of the sequence is ready to expose it.
0xadam-brown
force-pushed
the
feat/sentry-nav3-effect-4-effect
branch
from
cffd83e to
ef33ec7
Compare
September 18, 2026 13:08
…ffectTest setLogger(logger) resolved to SentryOptions.getLogger() via the apply receiver, setting the logger to its own default rather than a mock. Nothing asserts on the logger, so the line was misleading dead code.
0xadam-brown
commented
Sep 18, 2026
Comment thread
sentry-android-navigation3/src/main/kotlin/io/sentry/compose/navigation3/SentryNavEffect.kt
| @ApiStatus.Experimental | ||
| @Composable | ||
| @Suppress("FunctionNaming") | ||
| internal fun <T : Any> SentryNavEffect( |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
This will be the main public API for our Nav3 integration – at least for milestone 1. (Milestone 1 aims at Nav2 parity, including support of navigation where each entry in the back stack is interpreted as the currently visible screen).
Marked as experimental b/c this will be made public in a follow-on to the current PR stack.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Android Nav3)
📜 Description
Introduce SentryNavEffect, the Compose-facing abstraction for Android Nav3. This is the key abstraction for milestone 1 of our Nav3 support. (Milestone 1 aims at parity with Nav2, including support of navigation where each entry in the back stack is interpreted as the currently visible screen).
This PR connects the observer layer from #6131 to Compose lifecycle and recomposition behavior.
💡 Motivation and Context
SentryNavEffect is the key abstraction this integration presents to host apps. Keeping it in its own PR makes the public-facing shape and lifecycle model reviewable on their own, even while the symbol remains internal for now.
addresses: JAVA-274
💚 How did you test it?
📝 Checklist
🔮 Next steps
#skip-changelog