Repository navigation
feat(core): capture MCP OAuth client names per request - #24508
Draft
betegon wants to merge 2 commits into
Draft
betegon wants to merge 2 commits into
betegon wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
size-limit report 📦⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
|
Sorry, something went wrong.
betegon
marked this pull request as ready for review
October 5, 2026 11:34
betegon
requested review from
andreiborza and
mydea
and removed request for
a team
October 5, 2026 11:34
betegon
marked this pull request as draft
October 5, 2026 11:35
Co-Authored-By: GPT-6 (Codex) <codex@openai.com>
Co-Authored-By: GPT-6 (Codex) <codex@openai.com>
betegon
force-pushed
the
feat/mcp-oauth-client-name
branch
from
9b2892f to
914fd50
Compare
October 5, 2026 14:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
Assignees
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies: stacked on #25059. Sentry conventions #671 is merged; a release containing it must be published before this PR can merge, followed by updating the SDK dependency and lockfile to that release. This PR imports MCP_AUTH_CLIENT_NAME directly; the latest published release, 0.26.0, does not export it. Local validation used the package built from #671 without committing a local override or inventing a release version.
OAuth registration can identify a different application from MCP clientInfo, but transport AuthInfo has no standard client name. Add an opt-in getOAuthClientName resolver that records the registered name as the Sentry extension mcp.auth.client.name, independently of mcp.client.name.
Resolve the name once per incoming MCP request, including discovery and unsupported methods. The callback receives clientId and application-defined extra metadata when available and may read existing request-scoped authentication context. Only the returned name is recorded; resolver failures leave dispatch intact. Options follow the wrapper's existing first-explicit-value behavior, including manual configuration after auto-instrumentation.
The distinction follows MCP client registration. Real HTTP coverage exercises both MCP SDK majors in ESM/CJS, concurrent requests, and missing identities. Network metadata remains in #24506 and canonical attribute adoption in #25060; each builds on the common imports PR.