Repository navigation
fix(nuxt): Stop double-instrumenting storage on Nitro 3 - #24869
Closed
mydea wants to merge 6 commits into
Closed
mydea wants to merge 6 commits into
mydea wants to merge 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mydea
added this pull request to stack #24871
September 30, 2026 08:41
Copy link
Copy Markdown
There was a problem hiding this comment.
Stale Bugbot comment from a previous run.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
size-limit report 📦⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.
|
Sorry, something went wrong.
mydea
force-pushed
the
feat/nitro-move-to-server-utils
branch
from
050cf3f to
5382539
Compare
September 30, 2026 11:01
mydea
force-pushed
the
feat/nuxt-strip-duplicate-nitro-instrumentation
branch
from
9c52353 to
302eaf2
Compare
September 30, 2026 11:01
Copy link
Copy Markdown
There was a problem hiding this comment.
Stale Bugbot comment from a previous run.
Sorry, something went wrong.
mydea
force-pushed
the
feat/nuxt-strip-duplicate-nitro-instrumentation
branch
from
302eaf2 to
9891641
Compare
September 30, 2026 11:06
mydea
force-pushed
the
feat/nuxt-strip-duplicate-nitro-instrumentation
branch
from
9891641 to
f882315
Compare
September 30, 2026 11:32
Copy link
Copy Markdown
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f882315. Configure here.
Sorry, something went wrong.
mydea
force-pushed
the
feat/nitro-move-to-server-utils
branch
from
e8a310d to
810fa6c
Compare
September 30, 2026 12:26
mydea
force-pushed
the
feat/nuxt-strip-duplicate-nitro-instrumentation
branch
from
874455e to
9cfef61
Compare
September 30, 2026 12:26
mydea
marked this pull request as ready for review
September 30, 2026 12:30
mydea
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
September 30, 2026 12:30
mydea
marked this pull request as draft
September 30, 2026 14:06
…itro 3 On Nitro 3, `nitroIntegration` (auto-injected via `@sentry/node` defaults) instruments unstorage through its native tracing channels, while the Nuxt storage plugin instruments the same operations manually — so each cache operation is recorded twice (`auto.cache.nitro` + `auto.cache.nuxt`). This test asserts the target state (instrumented once, by nitroIntegration) and fails until the duplicate Nuxt storage instrumentation is removed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
On Nitro 3, `@sentry/server-utils`' `nitroIntegration` (auto-injected via `@sentry/node`'s default integrations) already instruments unstorage through its native tracing channels. Nuxt's own storage plugin instrumented the same operations manually, so every cache operation was recorded twice (`auto.cache.nitro` + `auto.cache.nuxt`). Register the Nuxt storage plugin only on legacy Nitro (v2), which has no native channels, and delete the now-unused Nitro 3 plugin. The shared `instrumentStorage` util stays for the legacy path. Updates the nuxt-5 e2e assertions to the `auto.cache.nitro` spans and makes the duplicate-detection test pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
It asserted the absence of `auto.cache.nuxt` spans, but that origin no longer exists once the Nuxt storage plugin is removed on Nitro 3. The existing cache tests already cover the `auto.cache.nitro` spans. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…filter After the storage strip, Nitro 3 cache spans come from `nitroIntegration` with origin `auto.cache.nitro` instead of `auto.cache.nuxt`. `isCacheEvent` only recognised the latter, so a standalone cache transaction named after its operation (e.g. `cache.get`) was treated as a file request (the `.get` extension) and dropped by `lowQualityTransactionsFilter`. Recognise both origins, and add coverage. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Reverts the earlier removal. The `auto.cache.nuxt` code path still exists for legacy Nitro 2, so asserting that Nitro 3 records each cache operation exactly once (only `auto.cache.nitro`, never `auto.cache.nuxt`) remains a useful guard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Enable Nitro's `tracingChannel` on Nitro 3 so the srvx/h3/unstorage tracing channels fire, and add `nitroIntegration` to the Nuxt server SDK explicitly (via `addIntegration` after init, so `initNode` still resolves env-based tracing). Together with removing Nuxt's own storage instrumentation on Nitro 3, this makes Nuxt use the shared `@sentry/server-utils` Nitro instrumentation for HTTP and cache spans instead of its bespoke copy. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
force-pushed
the
feat/nuxt-strip-duplicate-nitro-instrumentation
branch
from
9cfef61 to
b515709
Compare
September 30, 2026 14:13
Copy link
Copy Markdown
Member
Author
|
actually, this fails on nuxt 5, so closing this pr |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #24861.
On Nitro 3, @sentry/server-utils' nitroIntegration — auto-injected via @sentry/node's default integrations (see the parent PR) — instruments unstorage through its native tracing channels. Nuxt's own storage plugin instruments the same operations manually, so on Nitro 3 every cache operation was recorded twice: once as auto.cache.nitro and once as auto.cache.nuxt.
This registers the Nuxt storage plugin only on legacy Nitro (v2) (which has no native tracing channels), and deletes the now-redundant Nitro 3 plugin. The shared instrumentStorage util stays for the legacy path — Nuxt's implementation and the server-utils captureStorageEvents it now defers to are near-identical siblings.
The first commit adds a failing nuxt-5 (Nitro 3) e2e test that asserts each cache operation is instrumented exactly once; the second commit removes the duplication and updates the existing auto.cache.nuxt assertions to the auto.cache.nitro spans.
🤖 Generated with Claude Code