Repository navigation
fix(nuxt): Remove redundant Nitro 3 route-name plugin - #24880
Closed
mydea wants to merge 1 commit into
Closed
mydea wants to merge 1 commit into
mydea wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mydea
added this pull request to stack #24871
September 30, 2026 11:08
Copy link
Copy Markdown
Contributor
size-limit report 📦
|
Sorry, something went wrong.
mydea
force-pushed
the
feat/nuxt-strip-duplicate-nitro-instrumentation
branch
from
9891641 to
f882315
Compare
September 30, 2026 11:32
mydea
force-pushed
the
feat/nuxt-strip-update-route-name
branch
2 times, most recently
from
fb27207 to
f4bd6ae
Compare
September 30, 2026 11:58
mydea
force-pushed
the
feat/nuxt-strip-duplicate-nitro-instrumentation
branch
from
874455e to
9cfef61
Compare
September 30, 2026 12:26
mydea
force-pushed
the
feat/nuxt-strip-update-route-name
branch
from
f4bd6ae to
2a97f05
Compare
September 30, 2026 12:26
mydea
marked this pull request as ready for review
September 30, 2026 12:30
mydea
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
September 30, 2026 12:30
Comment thread
packages/nuxt/src/module.ts
Comment on lines
112
to
121
|
|
||
| if (isNitroV3) { | ||
| addServerPlugin(moduleDirResolver.resolve('./runtime/plugins/handler.server')); | ||
| addServerPlugin(moduleDirResolver.resolve('./runtime/plugins/update-route-name.server')); | ||
| // On Nitro 3, the parametrized route name and `url.path.parameter.*` attributes are set by | ||
| // `@sentry/server-utils`' `nitroIntegration` (auto-injected via `@sentry/node` defaults) for | ||
| // API routes, and by `route-detector.server` for SSR page routes, so no Nuxt route-name | ||
| // plugin is needed. Legacy Nitro (v2) has no such channels and keeps its own. | ||
| } else { | ||
| addServerPlugin(moduleDirResolver.resolve('./runtime/plugins/handler-legacy.server')); | ||
| addServerPlugin(moduleDirResolver.resolve('./runtime/plugins/update-route-name-legacy.server')); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Bug: Removing update-route-name.server results in generic API route transaction names when tracing is disabled, as the replacement nitroIntegration is only active with tracing.
Severity: MEDIUM
The update-route-name.server plugin should be retained to ensure API route names are correctly parameterized for all users, including those who do not have performance tracing enabled. This guarantees consistent behavior regardless of the user's tracing configuration.
Prompt for AI AgentReview the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: packages/nuxt/src/module.ts#L112-L121 Potential issue: The pull request removes the `update-route-name.server` Nitro plugin, assuming that the `nitroIntegration` will handle API route naming. However, the `nitroIntegration` is only added to default integrations when tracing is enabled (e.g., `tracesSampleRate` is set). For users who only use Sentry for error tracking without tracing, or who set `defaultIntegrations: false`, this change will cause Nitro API routes to have generic, unparameterized transaction names. The removed plugin was the sole mechanism ensuring correct route naming in these common configurations.
Did we get this right? 👍 / 👎 to inform future reviews.
Sorry, something went wrong.
mydea
marked this pull request as draft
September 30, 2026 14:06
On Nitro 3, `@sentry/server-utils`' `nitroIntegration` (auto-injected via `@sentry/node`'s defaults) already sets the parametrized route name and `url.path.parameter.*` attributes for API routes, and `route-detector.server` handles SSR page routes. Nuxt's `update-route-name.server` set the same attributes on the same span — redundant work with no extra telemetry — so it is removed for Nitro 3. Legacy Nitro (v2), which has no native tracing channels, keeps its own plugin, and the shared `updateRouteBeforeResponse` hook stays for the legacy and Cloudflare paths. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
force-pushed
the
feat/nuxt-strip-duplicate-nitro-instrumentation
branch
from
9cfef61 to
b515709
Compare
September 30, 2026 14:13
mydea
force-pushed
the
feat/nuxt-strip-update-route-name
branch
from
2a97f05 to
01d3ad1
Compare
September 30, 2026 14:13
Copy link
Copy Markdown
Member
Author
|
actually, this fails on nuxt 5, so closing this pr |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #24869.
On Nitro 3, @sentry/server-utils' nitroIntegration — auto-injected via @sentry/node's default integrations — already sets the parametrized route name (setHttpServerSpanRouteAttribute) and the url.path.parameter.* / params.* attributes for API routes, and route-detector.server handles SSR page routes (the /** catch-all case nitroIntegration skips). Nuxt's update-route-name.server set the exact same attributes on the same span.
Unlike the storage duplication (#24869), this produced no duplicate spans — just redundant, idempotent attribute writes — so there's no behavior change, only a cleanup. The v3 update-route-name.server plugin is removed; the shared updateRouteBeforeResponse hook stays (still used by the legacy Nitro 2 plugin and the Cloudflare plugin), and legacy Nitro keeps its own route-name plugin.
🤖 Generated with Claude Code