(3) Move tracing related functions from Hub to Scope - #2558
Merged
antonpirker merged 44 commits intoDec 19, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…y-python into antonpirker/refactor-hub
antonpirker
changed the base branch from
master
to
antonpirker/refactor-hub-capture
December 1, 2023 12:46
antonpirker
marked this pull request as ready for review
December 5, 2023 09:26
sentrivana
approved these changes
Dec 12, 2023
sentrivana
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good to me. This stuff also fits better on the scope conceptually.
Sorry, something went wrong.
Comment thread
sentry_sdk/scope.py
Outdated
…scopes the hub is removed and the root level API directly calls it on the scope
Co-authored-by: Ivana Kellyerova <ivana.kellyerova@sentry.io>
sl0thentr0py
approved these changes
Dec 18, 2023
sl0thentr0py
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
this one is good because this stuff conceptually now belongs together with propagation context 👍
Sorry, something went wrong.
Moved some functionality from Hub to Client: - moved `start_transaction` from Hub to Scope - moved `start_span` from Hub to Scope - moved `continue_trace` from Hub to Scope This is preparation work for refactoring how we deal with Hubs and Scopes in the future. Depends on: #2558 (please review the linked one first)
Base automatically changed from
antonpirker/refactor-hub-capture
to
feat/new-scopes
December 19, 2023 11:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved some functionality from Hub to Client:
This is preparation work for refactoring how we deal with Hubs and Scopes in the future.
Depends on: #2555 (please review the linked one first)