(4) Move transaction/span related functions from Hub to Scope - #2564
Merged
antonpirker merged 7 commits intoDec 19, 2023
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
antonpirker
changed the base branch from
master
to
antonpirker/refactor-hub-tracing
December 4, 2023 15:07
…ctor-hub-transaction-span-continue-trace
antonpirker
marked this pull request as ready for review
December 5, 2023 12:04
sentrivana
approved these changes
Dec 14, 2023
sl0thentr0py
approved these changes
Dec 18, 2023
sl0thentr0py
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm, just some observations
Sorry, something went wrong.
antonpirker
deleted the
antonpirker/refactor-hub-transaction-span-continue-trace
branch
December 19, 2023 08:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved some functionality from Hub to Client:
This is preparation work for refactoring how we deal with Hubs and Scopes in the future.
Depends on: #2558 (please review the linked one first)