Revert "UnboundList: More compact string representation" - #22620
Merged
hvitved merged 1 commit intoSep 18, 2026
Merged
hvitved merged 1 commit into
hvitved merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The public PR description must remove its link to the internal repository issue.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: None
Reverts the compact UnboundList encoding after observed performance regressions.
Changes:
- Restores decimal rank encoding.
- Restores decimal-specific parsing and prefix matching.
| File | Description |
|---|---|
| shared/util/codeql/util/UnboundList.qll | Reverts compact encoding and related regexes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
aschackmull
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surprisingly, the DCA run after addressing review comments revealed performance regressions (the run before didn't). I'll revert while finding out why.