UnboundList: More compact string representation take 2 - #22623
Open
hvitved wants to merge 2 commits into
Open
hvitved wants to merge 2 commits into
hvitved wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This reverts commit 3fedfbb.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The optimizer-sensitive change should receive successful DCA performance validation before approval.
Review effort: Balanced
Findings: None
Reapplies compact ASCII encoding for UnboundList while correcting the join order that caused the earlier performance regression.
Changes:
- Encodes element ranks using printable ASCII characters excluding ..
- Updates list parsing regexes for the new encoding.
- Adds binding and late-inlining hints to singleton construction.
| File | Description |
|---|---|
| shared/util/codeql/util/UnboundList.qll | Implements compact encoding and join-order optimization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
aschackmull
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the revert and adds a needed join-order fix.