| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
Thanks for your submission @luchua-bc. I added some inline comments.
Sorry, something went wrong.
|
Hey @luchua-bc. I reviewed your changes and took the liberty of adjusting some things.
|
Sorry, something went wrong.
|
Thanks @atorralba a lot for the changes and the detailed explanation. I learned a new way to make the query more concise:-) |
Sorry, something went wrong.
Co-authored-by: Chris Smowton <smowton@github.com>
|
Thanks for your review @smowton. @luchua-bc, I applied @smowton's comments regarding the rewrite I pushed. All the other suggestions are yours to handle :) |
Sorry, something went wrong.
Add clarification comments to PathMatchGuard
|
Thanks @atorralba for those new commits. I've made changes for all the other suggestions. @smowton - please let me know if more changes are needed. Thanks. |
Sorry, something went wrong.
* Always sanitize after the second guard, not the first * Only check basic-block dominance in one place * One BarrierGuard extension per final guard
|
Thanks a lot for all the help from @atorralba and @smowton. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Directly incorporating user input into HTTP requests dispatched from the Java EE RequestDispatcher without proper validation of the input can allow any web application resource such as configuration files and source code to be disclosed.
As stated in the Java API doc, when using a Java EE RequestDispatcher, requests may be dispatched to any part of the web application bypassing both implicit (no direct access to WEB-INF or META-INF) and explicit (defined by the web application) security constraints. Unsanitized user provided data must not be used to construct the path passed to the RequestDispatcher as it is very likely to create a security vulnerability in the application.
This query detects unsafe invocations of RequestDispatcher with user controlled input. Important features include:
The query was previously submitted then closed to wait for the closing of another relevant PR. The current query provided further enhancement in addition to new scenarios and was validated against published CVEs.
Please consider to merge the PR. Thanks.