FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

CWE-552: Switch to the shared PathSanitizer library by luchua-bc · Pull Request #8055 · github/codeql · GitHub

/ codeql Public

CWE-552: Switch to the shared PathSanitizer library - #8055

Merged
atorralba merged 1 commit into
github:mainfrom
luchua-bc:java/unsafe-url-forward-with-shared-lib
Feb 23, 2022
Merged

CWE-552: Switch to the shared PathSanitizer library#8055
atorralba merged 1 commit into
github:mainfrom
luchua-bc:java/unsafe-url-forward-with-shared-lib

Conversation

Copy link
Copy Markdown
Contributor

Following up on the discussion at PR# 7712, this PR is to update the query committed by PR# 7286 - Java: CWE-552 Query to detect unsafe request dispatcher usage to switch to the shared library experimental.semmle.code.java.PathSanitizer.

With this change, code reusability is improved and it facilitates the future integration once the shared library is promoted from the experimental directory to the main directory.

Please consider to merge the PR. Thanks.

luchua-bc requested a review from a team as a code owner February 16, 2022 16:18
github-actions Bot added the Java label Feb 16, 2022

luchua-bc commented Feb 16, 2022
edited
Loading

Copy link
Copy Markdown
Contributor Author

@smowton and @atorralba - please review this PR when you have a chance.

And I guess you will submit the PR to promote the PathSanitizer library to main since you will fine tune the library. Please advise if you want me to submit that PR instead. Thanks.

atorralba merged commit f011bbc into github:main Feb 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL