Add telemetry for TRAP caching - #1182
Merged
edoardopirovano merged 2 commits intoAug 16, 2022
Merged
edoardopirovano merged 2 commits into
edoardopirovano merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
edoardopirovano
force-pushed
the
edoardo/trap-cache-telemetry
branch
from
3b448b5 to
6162433
Compare
August 15, 2022 16:59
Copy link
Copy Markdown
Contributor
Author
|
Changing to draft as we need a difference dependency with a more open license. |
Sorry, something went wrong.
edoardopirovano
force-pushed
the
edoardo/trap-cache-telemetry
branch
from
6162433 to
20daf81
Compare
August 16, 2022 09:58
edoardopirovano
force-pushed
the
edoardo/trap-cache-telemetry
branch
from
9f4066c to
7a0f475
Compare
August 16, 2022 10:18
edoardopirovano
force-pushed
the
edoardo/trap-cache-telemetry
branch
from
7d3ceb9 to
4139682
Compare
August 16, 2022 10:54
Copy link
Copy Markdown
Contributor
Author
|
This is now ready for review again. |
Sorry, something went wrong.
henrymercer
reviewed
Aug 16, 2022
Comment thread
src/init-action.ts
Outdated
Comment thread
src/config-utils.ts
Comment thread
src/config-utils.ts
Outdated
Comment thread
src/analyze-action.ts
Comment thread
src/analyze-action.ts
Outdated
Comment thread
src/analyze-action.ts
Outdated
Comment thread
src/trap-caching.ts
Outdated
henrymercer
approved these changes
Aug 16, 2022
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Minor comment around the get-folder-size package, otherwise LGTM.
Sorry, something went wrong.
3 tasks
This was referenced Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some telemetry for TRAP caching including the times and sizes of the cache uploads/downloads and the languages that we are using TRAP caching for. Almost all of the code change is adding a dependency that computes the recursive size of folders. This is a little jarring, but is I think simpler than writing that code ourselves which is potentially somewhat awkward. I'm definitely open to other suggestions on if there's a simpler way to get the size of the cache, though.
Merge / deployment checklist