Use util.promisify instead of manually constructing promise - #1184
Merged
edoardopirovano merged 1 commit intoAug 16, 2022
Merged
edoardopirovano merged 1 commit into
edoardopirovano merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
henrymercer
approved these changes
Aug 16, 2022
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice!
Sorry, something went wrong.
edoardopirovano
enabled auto-merge
August 16, 2022 13:58
This was referenced Aug 17, 2022
This was referenced Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a minor follow-up comment from @henrymercer in #1182.
Merge / deployment checklist