Submit SARIF for failed runs too - #1393
Merged
henrymercer merged 23 commits intoDec 2, 2022
Merged
henrymercer merged 23 commits into
henrymercer merged 23 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
henrymercer
force-pushed
the
henrymercer/report-failed-runs
branch
from
39c59d2 to
7cef3cf
Compare
November 25, 2022 16:17
henrymercer
force-pushed
the
henrymercer/report-failed-runs
branch
from
91edebd to
61ec68f
Compare
November 25, 2022 18:00
henrymercer
force-pushed
the
henrymercer/report-failed-runs
branch
from
61ec68f to
7fc3c60
Compare
November 25, 2022 18:18
henrymercer
marked this pull request as ready for review
November 25, 2022 18:25
3 tasks
aeisenberg
reviewed
Nov 29, 2022
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Partial review only.
Sorry, something went wrong.
aeisenberg
reviewed
Nov 29, 2022
Comment thread
src/feature-flags.ts
Comment thread
src/init-action-post-helper.ts
Comment thread
src/workflow.ts
Outdated
aeisenberg
reviewed
Nov 29, 2022
Comment thread
src/init-action-post-helper.test.ts
Comment thread
src/upload-lib.ts
Outdated
Comment thread
src/upload-lib.ts
Outdated
aeisenberg
reviewed
Dec 1, 2022
Comment thread
src/upload-lib.ts
Outdated
aeisenberg
approved these changes
Dec 2, 2022
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice!
Sorry, something went wrong.
This was referenced Dec 8, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR helps us better surface failed code scanning workflow runs by attempting to submit a SARIF file containing executionSuccessful: false in some of these cases. We take special care to ensure that we respect SARIF categories and upload: false options to avoid stale tips. This is made more difficult by the fact that these are only passed to the analyze Action. We want to handle cases where the workflow fails before the analyze step, and we don't have access to these inputs in the post-init step. Therefore we resort to a best-effort attempt at working out what the inputs were based on the workflow file and the variables we do have access to in the post-init step.
We don't to cover every case where the workflow fails here. Cases where the workflow run is cancelled or times out won't be possible to handle — we'd need a different mechanism to notify Code Scanning about these. However this PR will cover many of the cases where workflows fail so we can start providing a better experience.
Merge / deployment checklist