Improve reporting failed runs via SARIF - #1444
Merged
henrymercer merged 7 commits intoJan 4, 2023
Merged
henrymercer merged 7 commits into
henrymercer merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This doesn’t affect the overall behaviour, but means we can short-circuit slightly more quickly when `analyze` is passed `upload: false`.
We now report errors via telemetry, and this feature will shortly be enabled by default.
angelapwen
reviewed
Dec 21, 2022
Comment thread
src/init-action-post-helper.ts
angelapwen
previously approved these changes
Dec 21, 2022
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
✅, optionally could rename uploadFailedSarif function 😸
Sorry, something went wrong.
Test results directly via return value of `testFailedSarifUpload` vs via checking log messages.
angelapwen
approved these changes
Dec 27, 2022
angelapwen
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good, thanks for renaming + adding extra tests! 😄
Sorry, something went wrong.
This was referenced Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes some minor improvements to the way we report failed runs via SARIF. The first commit adjusts the pre-check to check whether the analyze Action has completed, to allow a quicker short circuit exit when upload: false is specified but the workflow run was successful. The remaining commits improve error messages.
Merge / deployment checklist