Merge releases/v2 into releases/v1 - #1478
Merged
henrymercer merged 52 commits intoJan 12, 2023
Merged
henrymercer merged 52 commits into
henrymercer merged 52 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Mergeback v2.1.37 refs/heads/releases/v2 into main
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
…ests Remove tests with old certifi dependency
This doesn’t affect the overall behaviour, but means we can short-circuit slightly more quickly when `analyze` is passed `upload: false`.
We now report errors via telemetry, and this feature will shortly be enabled by default.
Test results directly via return value of `testFailedSarifUpload` vs via checking log messages.
Ensure we are regularly running code scanning using the latest CodeQL and remain up to date with the internal security scorecard, even if we have a period longer than a week with no pushes to the repo.
…ng-schedule Code scanning: Add scheduled trigger to workflow
…-improvements Improve reporting failed runs via SARIF
Refactor CodeQL setup
This commit does a few related things: 1. Bumps the minimum version for cli config parsing to 2.10.6 2. Ensures that if cli config parsing is enabled, then remove repos are _not_ downloaded by the action. It happens in the CLI. 3. Passes the `--external-repository-token-stdin` option to the CLI and passes the appropriate token via stdin if cli config parsing is enabled.
…tream Use a stream when uploading database contents
henrymercer
marked this pull request as ready for review
January 12, 2023 10:42
henrymercer
approved these changes
Jan 12, 2023
henrymercer
enabled auto-merge
January 12, 2023 10:43
Comment thread
src/database-upload.ts
Comment on lines
+50
to
+61
| { | ||
| owner: repositoryNwo.owner, | ||
| repo: repositoryNwo.repo, | ||
| language, | ||
| name: `${language}-database`, | ||
| data: bundledDbReadStream, | ||
| headers: { | ||
| authorization: `token ${apiDetails.auth}`, | ||
| "Content-Type": "application/zip", | ||
| "Content-Length": bundledDbSize, | ||
| }, | ||
| } |
Check warning
Code scanning / CodeQL
File data in outbound network request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging 515828d into releases/v1
Conductor for this PR is @henrymercer.
Contains the following pull requests:
Please do the following: