FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Send the external repository token to the CLI by aeisenberg · Pull Request #1464 · github/codeql-action · GitHub

/ codeql-action Public

Send the external repository token to the CLI - #1464

Merged
aeisenberg merged 3 commits into
mainfrom
aeisenberg/externalRepoTokenConfigParsing
Jan 10, 2023
ConversationCommits (3)ChecksFiles changed
Merged

Send the external repository token to the CLI#1464
aeisenberg merged 3 commits into
mainfrom
aeisenberg/externalRepoTokenConfigParsing

Conversation

aeisenberg commented Jan 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This commit does a few related things:

  1. Bumps the minimum version for cli config parsing to 2.10.6
  2. Ensures that if cli config parsing is enabled, then remove repos
    are not downloaded by the action. It happens in the CLI.
  3. Passes the --external-repository-token-stdin option to the CLI
    and passes the appropriate token via stdin if cli config parsing is
    enabled.

See the linked, internal PR for the integration test associated with this change.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

aeisenberg requested a review from a team as a code owner January 6, 2023 01:35
aeisenberg marked this pull request as draft January 6, 2023 01:35
aeisenberg removed the request for review from a team January 6, 2023 01:35
aeisenberg force-pushed the aeisenberg/externalRepoTokenConfigParsing branch 5 times, most recently from b62c79e to c17dc61 Compare January 6, 2023 22:33
Send the external repository token to the CLI
4023575 
This commit does a few related things:

1. Bumps the minimum version for cli config parsing to 2.10.6
2. Ensures that if cli config parsing is enabled, then remove repos
   are _not_ downloaded by the action. It happens in the CLI.
3. Passes the `--external-repository-token-stdin` option to the CLI
   and passes the appropriate token via stdin if cli config parsing is
   enabled.
aeisenberg force-pushed the aeisenberg/externalRepoTokenConfigParsing branch from c17dc61 to 4023575 Compare January 6, 2023 22:46

aeisenberg commented Jan 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Failing test is because the cached version of the cli is too old to be using cli config parsing now, so the cli config files are not generated. The test will start passing when the cached version becomes 2.11.6.

aeisenberg marked this pull request as ready for review January 7, 2023 00:18
aeisenberg requested review from a team and henrymercer January 7, 2023 00:18

aeisenberg commented Jan 10, 2023

Copy link
Copy Markdown
Contributor Author

@henrymercer, I think you are the one with the most background to review. Can you take a look?

henrymercer previously approved these changes Jan 10, 2023
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A few minor comments, but this looks generally good to me 👍

Comment thread src/codeql.ts Outdated
Comment thread src/codeql.ts Outdated
Comment thread src/codeql.ts Outdated

aeisenberg commented Jan 10, 2023

Copy link
Copy Markdown
Contributor Author

Failures due to using a kotlin version that is too new. Updating the base branch should fix it.

aeisenberg enabled auto-merge January 10, 2023 20:45
aeisenberg merged commit 42d6d35 into main Jan 10, 2023
aeisenberg deleted the aeisenberg/externalRepoTokenConfigParsing branch January 10, 2023 22:03
This was referenced Jan 12, 2023
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

henrymercer henrymercer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL