Add CLI version field and prior release fields to defaults file - #1463
Merged
angelapwen merged 2 commits intoJan 6, 2023
Merged
angelapwen merged 2 commits into
angelapwen merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
henrymercer
approved these changes
Jan 6, 2023
henrymercer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Worth noting that the CLI version of each bundle is derivable by downloading the bundle release and running codeql version. However I think it make sense to include it here, as it will simplify the runner image creation scripts and other scripts processing this file.
Sorry, something went wrong.
This was referenced Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to have more fine-grained control the CLI version present in the toolcache, we will be downloading the most recent 2 versions of the CLI bundle to the toolcache and selecting a version (based on feature flag rollout of the most recent version) for the Action.
The runner image script selects the bundle from the defaults file to determine which version of CodeQL to download. This change adds the bundle release prior to the most recent release under the field priorBundleVersion so that it is able to download both versions. We keep the bundleVersion field named the same to maintain backwards compatibility so that this change can be merged independently of the other changes in the Action.
The change also adds the CLI version for both the most recent release, and the prior release, so that the versions downloaded to the toolcache can be named appropriately (currently they are all prefixed with 0.0.0 rather than the actual x.y.z version of the CodeQL bundle.
Merge / deployment checklist