FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update bundle to 2.12.0 by dbartol · Pull Request #1466 · github/codeql-action · GitHub

Update bundle to 2.12.0 - #1466

Merged
dbartol merged 8 commits into
mainfrom
dbartol/bundle-20230105
Jan 10, 2023
Merged

dbartol merged 8 commits into
mainfrom
dbartol/bundle-20230105

Conversation

dbartol commented Jan 6, 2023
edited
Loading

Copy link
Copy Markdown

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

dbartol requested a review from a team as a code owner January 6, 2023 16:01
dbartol marked this pull request as draft January 6, 2023 16:01

Copy link
Copy Markdown
Contributor

Hi — I've just merged #1463 which creates some merge conflicts here. We'll be updating the release documentation shortly to include this, but wanted to write an FYI that we've added a few fields to the file that include the actual version number of the current release, as well as the bundle name + version number of the previous release 😄 let me know if any questions!

dbartol commented Jan 6, 2023

Copy link
Copy Markdown
Author

@angelapwen Thanks for the heads up!

henrymercer previously approved these changes Jan 6, 2023
dbartol marked this pull request as ready for review January 10, 2023 14:30
dbartol enabled auto-merge January 10, 2023 14:30
Comment thread CHANGELOG.md
## [UNRELEASED]

No user facing changes.
- Update default CodeQL bundle version to 2.12.0. [#1466](https://github.com/github/codeql-action/pull/1466)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Something minor and doesn't need to happen for this release, but perhaps we should start linking to the release notes for the CLI version we are upgrading to.

aeisenberg previously approved these changes Jan 10, 2023

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

To be clear...this integration test will continue to fail until it starts using a version of the CLI that supports kotlin 1.8.0?

I think that is fine, but if this gets annoying, we should disable this test in main and create an issue to remind ourselves to re-enable it.

henrymercer and others added 3 commits January 10, 2023 17:31
Kotlin analysis is incompatible with Kotlin 1.8.0, which is now rolling
out to the Actions runner images.

While we work on a more permanent fix to our PR checks, this will
prevent us losing other
test coverage.
…kotlin-in-pr-checks

Temporarily disable Kotlin analysis in PR checks
henrymercer dismissed stale reviews from aeisenberg and themself via f12f76f January 10, 2023 19:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL