Temporarily disable Kotlin analysis in PR checks - #1473
Merged
henrymercer merged 2 commits intoJan 10, 2023
Merged
henrymercer merged 2 commits into
henrymercer merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Kotlin analysis is incompatible with Kotlin 1.8.0, which is now rolling out to the Actions runner images. While we work on a more permanent fix to our PR checks, this will prevent us losing other test coverage.
henrymercer
marked this pull request as ready for review
January 10, 2023 17:51
aeisenberg
approved these changes
Jan 10, 2023
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I think this is reasonable for what we need. Did you create an issue to track this?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Backlink added to internal issue :) |
Sorry, something went wrong.
henrymercer
deleted the
henrymercer/temporarily-disable-kotlin-in-pr-checks
branch
January 10, 2023 19:49
This was referenced Jan 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kotlin analysis is incompatible with Kotlin 1.8.0, which is now rolling out to the Actions runner images.
While we work on a more permanent fix to our PR checks, this will prevent us losing other test coverage.
Merge / deployment checklist