FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Re-enable kotlin tests by aeisenberg · Pull Request #1939 · github/codeql-action · GitHub

/ codeql-action Public

Re-enable kotlin tests - #1939

Merged
aeisenberg merged 7 commits into
mainfrom
aeisenberg/enable-kotlin-tests
Jun 17, 2024
ConversationCommits (7)ChecksFiles changed
Merged

Re-enable kotlin tests#1939
aeisenberg merged 7 commits into
mainfrom
aeisenberg/enable-kotlin-tests

Conversation

aeisenberg commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

Reverts #1473

aeisenberg requested a review from a team as a code owner October 10, 2023 23:09

aeisenberg commented Oct 11, 2023

Copy link
Copy Markdown
Contributor Author

Hmmm...now it's failing, but because there's an even newer version of kotlin. We are going to need to choose a specific version of kotlin based on the version of the CLI.

aeisenberg force-pushed the aeisenberg/enable-kotlin-tests branch 4 times, most recently from a572e6d to c5f043e Compare October 13, 2023 22:20
Explicitly setup a kotlin version
fcf7c47 
Change the `prepare-test` action to conditionally setup kotlin.
aeisenberg force-pushed the aeisenberg/enable-kotlin-tests branch from c5f043e to fcf7c47 Compare October 13, 2023 22:25
aeisenberg marked this pull request as draft November 14, 2023 18:22

aeisenberg commented Nov 14, 2023

Copy link
Copy Markdown
Contributor Author

Converting to draft mode since I won't be able to work on this. If someone else wants to pick it up, please do so.

aeisenberg commented Feb 2, 2024

Copy link
Copy Markdown
Contributor Author

Not going to be able to get to this.

aeisenberg closed this Feb 2, 2024
aeisenberg reopened this Apr 1, 2024
aeisenberg closed this Jun 13, 2024
aeisenberg reopened this Jun 14, 2024
aeisenberg force-pushed the aeisenberg/enable-kotlin-tests branch from 11b4852 to dd6e97c Compare June 14, 2024 20:46
aeisenberg force-pushed the aeisenberg/enable-kotlin-tests branch from dd6e97c to a449977 Compare June 14, 2024 21:17
aeisenberg force-pushed the aeisenberg/enable-kotlin-tests branch 2 times, most recently from 1682ca4 to 7512620 Compare June 14, 2024 22:19
aeisenberg force-pushed the aeisenberg/enable-kotlin-tests branch from 7512620 to 31a716b Compare June 14, 2024 22:27
aeisenberg marked this pull request as ready for review June 14, 2024 22:36

aeisenberg commented Jun 14, 2024

Copy link
Copy Markdown
Contributor Author

This should now be working properly. The version of kotlin is fixed to 1.8.21. We can consider upgrading the version in the future, or even running against multiple versions if we like.

angelapwen approved these changes Jun 17, 2024
View reviewed changes

angelapwen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for getting back to this!! ✨

aeisenberg merged commit 35619fb into main Jun 17, 2024
aeisenberg deleted the aeisenberg/enable-kotlin-tests branch June 17, 2024 20:48
This was referenced Jun 28, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
angelapwen angelapwen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL