FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Upgrade to TypeScript 9.2.0 by henrymercer · Pull Request #1492 · github/codeql-action · GitHub

/ codeql-action Public

Upgrade to TypeScript 9.2.0 - #1492

Merged
henrymercer merged 11 commits into
mainfrom
henrymercer/upgrade-typescript
Jan 20, 2023
ConversationCommits (11)ChecksFiles changed
Merged

Upgrade to TypeScript 9.2.0#1492
henrymercer merged 11 commits into
mainfrom
henrymercer/upgrade-typescript

Conversation

henrymercer commented Jan 18, 2023

Copy link
Copy Markdown
Contributor

Now that we've dropped Node 12 support, we can upgrade to the latest version of TypeScript!

  • I've brought a bunch of other packages up to date, since we need to update our linter and test suite to be compatible with the new TypeScript version.
  • I've added type annotations to account for the stricter type checking that's now enabled.
  • I've bumped our compilation target from ES2019 to ES2021 (see https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping).

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

henrymercer requested a review from a team as a code owner January 18, 2023 20:59
henrymercer force-pushed the henrymercer/upgrade-typescript branch from 738afa7 to 0a11e3f Compare January 18, 2023 21:00
henrymercer mentioned this pull request Jan 18, 2023
Closed
Remove Node 12 compatibility check
d5dcff5
Add a .DS_Store file shipped with a dependency
4306b97 
We should be checking in all contents of the dependencies, including OS
junk!
henrymercer mentioned this pull request Jan 18, 2023
Merged
6 tasks

henrymercer commented Jan 19, 2023

Copy link
Copy Markdown
Contributor Author

@github/codeql-action-reviewers This is ready for review. The two checks that are still yellow have been removed, and we'll need to update the required checks prior to merging.

aeisenberg reviewed Jan 19, 2023
View reviewed changes

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice!

This was really hard to review since the PR tools in the browser just wasn't loading the code for me. Or I had to wait 10-15 seconds for rendering.

Comment thread src/codeql.ts Outdated
Comment thread src/codeql.ts
Comment thread src/autobuild-action.ts Outdated
Comment thread src/init-action.ts Outdated
Comment thread src/upload-sarif-action.ts Outdated
aeisenberg reviewed Jan 19, 2023
View reviewed changes

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A few minor comments for typing, but I think it's basically good.

henrymercer force-pushed the henrymercer/upgrade-typescript branch from 238f8f1 to 67c69d1 Compare January 20, 2023 14:56
henrymercer force-pushed the henrymercer/upgrade-typescript branch from 67c69d1 to 4beb395 Compare January 20, 2023 15:02
aeisenberg approved these changes Jan 20, 2023
View reviewed changes

aeisenberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

Comment thread src/codeql.ts
henrymercer merged commit 4827181 into main Jan 20, 2023
henrymercer deleted the henrymercer/upgrade-typescript branch January 20, 2023 16:28
github-actions Bot mentioned this pull request Jan 26, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aeisenberg aeisenberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL