Bump setup-swift and re-configure dependabot - #1560
Merged
angelapwen merged 4 commits intoMar 6, 2023
Merged
angelapwen merged 4 commits into
angelapwen merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
adityasharad
previously approved these changes
Mar 3, 2023
Comment thread
.github/dependabot.yml
| directory: "/" | ||
| schedule: | ||
| interval: weekly | ||
| - package-ecosystem: github-actions |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Perhaps comment here why we need this separately from the / pattern above. I understand / to mean "repo root and .github/workflows` and any other subdir needs explicit inclusion?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Yes, that's correct 👍 will do
Sorry, something went wrong.
angelapwen
enabled auto-merge (squash)
March 3, 2023 21:29
henrymercer
approved these changes
Mar 6, 2023
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our Swift extractor is now using Swift v5.7.3, but our setup-swift version was pinned to a prior version that doesn't support v5.7.3, so our CI is failing.
This change bumps setup-swift to its most recent release commit SHA (https://github.com/swift-actions/setup-swift/releases/tag/v1.22.0).
It also adds a new entry to the dependabot.yml file because Dependabot should have bumped this version — setup-swift v1.22.0 was released two weeks ago and we run Dependabot checks weekly. Per the dependabot maintainers, the filepath needed is the root of the repo (/.github/workflows is specially cased under /).
We also add a comment reminding the next person who approves a Dependabot update to manually update the SHA in the CLI's CodeQL Action Integration Test. (Note that we should also replicate the logic of finding the appropriate Swift version in the CLI's integration test).
Merge / deployment checklist