FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update bundle to 2.12.4 by dbartol · Pull Request #1561 · github/codeql-action · GitHub

Update bundle to 2.12.4 - #1561

Merged
dbartol merged 7 commits into
mainfrom
dbartol/bundle-2.12.4
Mar 9, 2023
Merged

dbartol merged 7 commits into
mainfrom
dbartol/bundle-2.12.4

Conversation

dbartol commented Mar 6, 2023

Copy link
Copy Markdown

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

Copy link
Copy Markdown
Contributor

I've pushed a fix for a bug in #1527 that meant we passed a --qlconfig=undefined argument when there was no qlconfig file. I've also merged in main to bring in #1560 which should fix the issues with setup-swift.

Copy link
Copy Markdown
Contributor

Thanks for the fix, @henrymercer. I've confirmed that it works locally. I created a PR against main to fix it there. #1564

dbartol marked this pull request as ready for review March 9, 2023 14:44
dbartol requested a review from a team as a code owner March 9, 2023 14:44
dbartol requested a review from henrymercer March 9, 2023 14:51

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

(My commits are merged into main so I'm not signing off on my own code)

dbartol enabled auto-merge March 9, 2023 15:03
dbartol merged commit e12a2ec into main Mar 9, 2023
dbartol deleted the dbartol/bundle-2.12.4 branch March 9, 2023 15:22
github-actions Bot mentioned this pull request Mar 10, 2023
6 tasks

Copy link
Copy Markdown

I've pushed a fix for a bug in #1527 that meant we passed a --qlconfig=undefined argument

Erm, yes, I’m running into this because the bundle has been updated (compared to the previous run of the action). But there’s no new release; how do I get the builds working again?

Copy link
Copy Markdown

Ah well, reverting to an earlier version codeql-bundle-20230105 worked.

Copy link
Copy Markdown
Contributor

Erm, yes, I’m running into this because the bundle has been updated (compared to the previous run of the action). But there’s no new release; how do I get the builds working again?

Hi @mirabilos — this fix was released in version 2.2.6 of the CodeQL Action. Please let us know if you still aren't able to use the latest bundle.

mirabilos commented Mar 20, 2023 via email

Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

We release the CodeQL Action using git tags, and release CodeQL Action Bundles using GitHub Releases. It looks like the tool you're using is only picking up on the GitHub Releases. We'd recommend configuring your workflow to use the v2 tag (for example uses: github/codeql-action/init@v2). We update this tag with each release.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL