Automate the bundle upgrade - #1630
Merged
henrymercer merged 6 commits intoApr 3, 2023
Merged
henrymercer merged 6 commits into
henrymercer merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This is a more standard location for these custom Actions.
adityasharad
previously approved these changes
Apr 3, 2023
adityasharad
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks reasonable. Minor suggestions only, and we can always improve over time.
Sorry, something went wrong.
Comment thread
.github/actions/update-bundle/index.ts
Outdated
Comment thread
.github/actions/update-bundle/index.ts
Outdated
Comment thread
.github/workflows/update-bundle.yml
Outdated
adityasharad
previously approved these changes
Apr 3, 2023
adityasharad
approved these changes
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR automates the process of updating the default CodeQL Bundle. This minimises error, speeds up the release process, and lets us more easily make changes to how we represent the default CodeQL Bundle within the Action.
The workflow is triggered when a new bundle release is taken out of draft and made pre-release. It automatically opens a PR to bump the default bundle, and adds a changelog note. The CLI release manager then just needs to take this PR out of draft to run the checks, approve and merge.
Commit-by-commit review recommended — the first commit moves internal Actions into .github/actions which generates a large diff.
For GitHub staff, see an example Actions run and PR generated by this workflow.
Merge / deployment checklist