Unset DYLD_INSERT_BINARIES when unneeded - #2428
Closed
angelapwen wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
angelapwen
force-pushed
the
angelapwen/unset-tracer-env-vars
branch
4 times, most recently
from
4fa88f5 to
2491c18
Compare
August 14, 2024 21:53
angelapwen
marked this pull request as ready for review
August 14, 2024 22:05
Comment thread
src/init-action.ts
Outdated
Comment thread
src/tracer-config.ts
Outdated
Comment thread
src/tracer-config.ts
Outdated
Copy link
Copy Markdown
Contributor
Author
|
Getting some unbound variable errors from the autobuilders. I'll test out only unsetting the variable that we need to fix this issue. |
Sorry, something went wrong.
angelapwen
marked this pull request as draft
August 14, 2024 22:53
angelapwen
force-pushed
the
angelapwen/unset-tracer-env-vars
branch
from
360bbc2 to
426ccd5
Compare
August 14, 2024 22:58
Previously, the tracer environment variables were set for the current process, and for future steps, in the init action. In certain scenarios (such as on MacOS ARM runners with System Integrity Protection disabled), these environment variables are not unset by the system. In particular, the `DYLD_INSERT_BINARIES` variable interferes with later system calls. This change unsets the `DYLD_INSERT_BINARIES` variable for the current process in init. It also unsets the variables either at the beginning of autobuild, or analyze, if autobuild has not run.
angelapwen
force-pushed
the
angelapwen/unset-tracer-env-vars
branch
from
426ccd5 to
954566e
Compare
August 15, 2024 00:30
angelapwen
marked this pull request as ready for review
August 15, 2024 00:46
Copy link
Copy Markdown
Contributor
Author
|
Hrm... hang on, still getting warnings related to the insertion when running on macos-latest so moving back to draft. |
Sorry, something went wrong.
angelapwen
marked this pull request as draft
August 15, 2024 00:49
Copy link
Copy Markdown
Contributor
Author
|
Closing as unsetting this variable doesn't seem to have done what we'd hoped. We will stop running the system binary instead for now: #2434 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot will automatically review once the pull request is marked ready for review
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the tracer environment variables were set for the
current process, and for future steps, in the init action. In
certain scenarios (such as on MacOS ARM runners with System
Integrity Protection disabled), these environment variables are
not unset by the system. In particular, the DYLD_INSERT_BINARIES
variable interferes with later system calls.
This change unsets the DYLD_INSERT_BINARIES variable for the
current process in init. It also unsets the variables either at the
beginning of autobuild, or analyze, if autobuild has not run.
Merge / deployment checklist