Stop checking disk usage for MacOS ARM with SIP disabled - #2434
Merged
angelapwen merged 2 commits intoAug 20, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
On MacOS ARM machines where SIP is disabled, after the build tracer is initialized in the `init` Action, we receive warnings when we run send status reports due to the `df` binary. This change will make it so that we no longer run `df` for those machines.
aeisenberg
approved these changes
Aug 20, 2024
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice
Sorry, something went wrong.
8 tasks
angelapwen
added a commit
that referenced
this pull request
Aug 21, 2024
* Consider registries_credentials as input * Clean-up logging * More debugging of credentials * Support URL * Validate credentials input * fixes * Try upload teh proxy logs * Update changelog and version after v3.26.3 * Update checked-in dependencies * Stop checking disk usage for MacOS ARM with SIP disabled (#2434) * Stop checking disk usage for MacOS ARM with SIP disabled On MacOS ARM machines where SIP is disabled, after the build tracer is initialized in the `init` Action, we receive warnings when we run send status reports due to the `df` binary. This change will make it so that we no longer run `df` for those machines. * Add deprecation message to `add-snippets` input. * Update changelog with deprecation. * Add link to PR deprecating `add-snippets` to CHANGELOG.md Co-authored-by: Andrew Eisenberg <aeisenberg@github.com> * Address incorrect changelog location * Update changelog for v3.26.4 --------- Co-authored-by: Marco Gario <marcogario@github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Henry Mercer <henry@henrymercer.name> Co-authored-by: Arthur Baars <aibaars@github.com> Co-authored-by: Angela P Wen <angelapwen@github.com> Co-authored-by: Remco Vermeulen <rvermeulen@github.com> Co-authored-by: Remco Vermeulen <rvermeulen@users.noreply.github.com> Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
8 tasks
aibaars
reviewed
Aug 22, 2024
Comment thread
src/util.ts
| if ( | ||
| process.platform === "darwin" && | ||
| (process.arch === "arm" || process.arch === "arm64") && | ||
| !(await isSipEnabled(logger)) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@angelapwen
I think isSipEnabled should not be called after the tracer has been initialised. Perhaps run it once in init and store the result with core.saveState() . The csrutil command is arm64e just like df.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On MacOS ARM machines where SIP is disabled, after the build tracer is initialized in the init Action, we receive warnings when we run send status reports due to the df binary. This change will make it so that we no longer run df for those machines.
Merge / deployment checklist