Add private registry URLs as output to the start-proxy Action - #2652
Merged
mbg merged 6 commits intoDec 16, 2024
Merged
mbg merged 6 commits into
mbg merged 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Files not reviewed (1)- pr-checks/.gitignore: Language not supported
lib/start-proxy-action.js:155
- The variable name 'registry_urls' should be 'registryUrls' to follow camelCase naming convention.
const registry_urls = config.all_credentials
Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more
Sorry, something went wrong.
Comment thread
src/start-proxy-action.ts
| core.setOutput("proxy_ca_certificate", config.ca.cert); | ||
|
|
||
| const registry_urls = config.all_credentials | ||
| .filter((credential) => credential.url !== undefined) |
Copilot
AI
Dec 13, 2024
Copy link
There was a problem hiding this comment.
The filter condition should use 'credential.url != null' instead of 'credential.url !== undefined' to properly filter out both 'undefined' and 'null' values.
Suggested change
| .filter((credential) => credential.url !== undefined) | |
| .filter((credential) => credential.url != null) |
Sorry, something went wrong.
Copilot uses AI. Check for mistakes.
marcogario
approved these changes
Dec 16, 2024
This was referenced Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
+1 more reviewerAdd this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist