Include registry type in proxy_urls output - #2672
mbg merged 2 commits into
Conversation
Sorry, something went wrong.
|
CI failures appear to be unrelated. |
Sorry, something went wrong.
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)lib/start-proxy-action.js:158
- Ensure that the type field in credential objects is always defined and correctly populated. If it can be undefined, handle it appropriately.
type: credential.type,
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Sorry, something went wrong.
CI will be passing with the release of v2.20.1 of the CLI. |
Sorry, something went wrong.
| .map((credential) => ({ | ||
| type: credential.type, | ||
| url: credential.url, | ||
| })); |
There was a problem hiding this comment.
This changes the shape of the proxy_urls output. Previously, it was just an array of strings. Is there anything that consumes proxy_urls that will break because of this change?
Sorry, something went wrong.
There was a problem hiding this comment.
I don't think so. I only added this before Christmas for a feature I am working on, and I don't expect anyone else to be using it yet. This action is also marked as experimental, so I wouldn't worry about this potentially being a breaking change externally.
Sorry, something went wrong.
|
Also, maybe the description of the output should be updated as well? https://github.com/github/codeql-action/blob/main/start-proxy/action.yml#L27. |
Sorry, something went wrong.
This is a follow-up to #2652 to include the registry type in the proxy_urls output. Since private registry configurations are org-wide, we may end up with registry configurations in a given workflow run that are not relevant to the particular language being analysed. Including the feed type in the list of configured registries allows extractors to identify the ones that relevant to them.