Revert "start-proxy: Skip proxy setup if no credentials are available" - #2740
Merged
marcogario merged 1 commit intoJan 29, 2025
Merged
Revert "start-proxy: Skip proxy setup if no credentials are available"#2740marcogario merged 1 commit into
marcogario merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)src/start-proxy-action.ts:102
- By removing the check for zero credentials, this code proceeds with proxy setup even if the credentials array is empty, which may lead to unexpected behavior or errors. Reintroduce a condition for the empty credentials scenario, or confirm that subsequent logic gracefully handles it.
logger.info(
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
Sorry, something went wrong.
marcogario
marked this pull request as draft
January 29, 2025 08:36
marcogario
marked this pull request as ready for review
January 29, 2025 08:41
marcogario
enabled auto-merge
January 29, 2025 09:01
NlightNFotis
approved these changes
Jan 29, 2025
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2724
The logic setting the proxy for maven fails with the empty variables. Though the error is non-fatal, this is not really improving the situation and might actually make it worse.