Merge main into releases/v3 - #2743
Merged
marcogario merged 14 commits intoJan 29, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Mergeback v3.28.6 refs/heads/releases/v3 into main
start-proxy: Remove unusued proxy_password input
start-proxy: Skip proxy setup if no credentials are available
Revert "start-proxy: Skip proxy setup if no credentials are available"
Properly unset proxy env if empty
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)src/analyze-action.ts:208
- This newly introduced code path for unsetting environment variables should be verified by tests to ensure correct behavior and avoid regressions. Please add or update tests covering the scenario where CODEQL_PROXY_HOST is empty.
if (process.env.CODEQL_PROXY_HOST === "") {
src/start-proxy-action.ts:103
- This early return for no credentials found should be included in test coverage to confirm the skipping of proxy setup does not introduce unexpected behavior. Please add or expand tests for this scenario.
if (credentials.length === 0) {
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Sorry, something went wrong.
marcogario
enabled auto-merge
January 29, 2025 13:00
marcogario
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
+1 more reviewerAssignees
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging 797fb30 into releases/v3.
Conductor for this PR is @marcogario.
Contains the following pull requests:
Please do the following: