Always make docker_registry registries available - #4024
Merged
mbg merged 1 commit intoJul 21, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Pull request overview
Makes Docker registry credentials available across all language workflows so the CodeQL CLI can access custom query packs.
Changes:
- Adds docker_registry to always-enabled registry types.
- Extends tests across Actions and all built-in languages.
| File | Description |
|---|---|
| src/start-proxy.ts | Always enables Docker registry credentials. |
| src/start-proxy.test.ts | Tests Docker credentials as always enabled. |
| lib/entry-points.js | Generated output; excluded by policy. |
Review details
Files excluded by content exclusion policy (1)- lib/entry-points.js
- Files reviewed: 2/3 changed files
- Comments generated: 0
- Review effort level: Medium
Sorry, something went wrong.
mario-campos
approved these changes
Jul 21, 2026
mario-campos
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
ellisonantoniafelicia-star
approved these changes
Jul 21, 2026
This comment has been minimized.
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A similar change as in #4000, which makes docker_registry registries always available to the workflow. The CLI can use Docker-style registries for custom query packs.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist