Always enable git_source registries - #4000
Merged
mbg merged 4 commits intoJul 10, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Pull request overview
This PR updates start-proxy’s registry-credential filtering so that git_source registries are always enabled, even when credentials are otherwise filtered by language. This aligns with the stated goal that git_source registries can be used by generic workflow components (not only language-specific ones).
Changes:
- Introduce an “always enabled” registry-type allowlist (currently git_source) and apply it during language-based filtering.
- Adjust registry-credential tests to cover the new always-enabled behavior.
| File | Description |
|---|---|
| src/start-proxy.ts | Adds an always-enabled registry-type list and updates credential filtering logic accordingly. |
| src/start-proxy.test.ts | Updates/extends tests to validate git_source credentials are always returned across languages. |
| lib/entry-points.js | Generated/excluded by policy (not reviewed). |
Review details
Files excluded by content exclusion policy (1)- lib/entry-points.js
- Files reviewed: 2/3 changed files
- Comments generated: 4
- Review effort level: Low
Sorry, something went wrong.
Comment thread
src/start-proxy.ts
Comment thread
src/start-proxy.ts
Comment thread
src/start-proxy.ts
Outdated
Comment thread
src/start-proxy.test.ts
mario-campos
approved these changes
Jul 10, 2026
mario-campos
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the language-based registry configuration filtering logic in the start-proxy action to always enable git_source registries since git_source registries are useful outside of language-specific contexts.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist