Migrate changetool to pr-checks - #4128
Merged
mbg merged 5 commits intoSep 10, 2026
Merged
mbg merged 5 commits into
mbg merged 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comment thread
pr-checks/changelog/validate.mts
Fixed
mbg
force-pushed
the
mbg/move-changetool
branch
from
19e9e17 to
d235931
Compare
September 9, 2026 10:44
mbg
marked this pull request as ready for review
September 9, 2026 10:47
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The migration preserves existing behavior, consolidates infrastructure cleanly, and passes the relevant tests and checks.
Review tier: Balanced
Findings: None
Migrates changetool into the shared pr-checks workspace while retaining ESM compatibility through .mts files.
Changes:
- Relocates changelog validation code and tests.
- Consolidates dependencies and TypeScript/ESLint configuration.
- Runs migrated tests through the existing PR-checks job.
| File | Description |
|---|---|
| .github/workflows/pr-checks.yml | Removes the redundant changetool test job. |
| eslint.config.mjs | Applies PR-checks linting to .mts files. |
| package-lock.json | Updates workspace and dependency resolution. |
| package.json | Removes the separate changetool workspace. |
| pr-checks/changelog/validate.mts | Relocates changelog validation logic. |
| pr-checks/changelog/validate.test.mts | Relocates and adapts validation tests. |
| pr-checks/package.json | Adds changetool dependencies. |
| pr-checks/tsconfig.json | Includes nested TypeScript and .mts sources. |
| pr-checks/validate-changelog.mts | Relocates and renames the CLI entry point. |
| scripts/changetool/package.json | Removes the obsolete standalone package. |
| scripts/changetool/tsconfig.json | Removes the obsolete standalone configuration. |
| tsconfig.json | Removes the deleted project from exclusions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
mario-campos
requested changes
Sep 9, 2026
Comment thread
pr-checks/changelog/validate.test.mts
Outdated
Comment thread
pr-checks/changelog/validate.test.mts
Comment thread
pr-checks/changelog/validate.test.mts
Comment thread
pr-checks/validate-changelog.mts
Copy link
Copy Markdown
Contributor
|
BTW, Thanks for putting this together for me! |
Sorry, something went wrong.
mario-campos
approved these changes
Sep 10, 2026
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to discussion on #4116 which migrates scripts/changetool from its own project to the common pr-checks project to avoid duplicated infrastructure.
Although changetool's two unique dependencies are ESM-only, we simply use the .mts extension for the migrated source files to avoid switching all of pr-checks over to ESM, which would require other modifications.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist