FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Migrate `changetool` to `pr-checks` by mbg · Pull Request #4128 · github/codeql-action · GitHub

  1. github
  2. codeql-action

Repository navigation

Migrate changetool to pr-checks #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbg merged 5 commits into from
Sep 10, 2026
Conversation 13 Commits 5 Checks 222 Files changed
Merged

Migrate changetool to pr-checks #4128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
83d1431
Migrate `changetool` to `pr-checks`
mbg Sep 9, 2026
b136352
Fix some formatting in `pr-checks.yml`
mbg Sep 9, 2026
d235931
Address linter errors in `validate.test.mts`
mbg Sep 9, 2026
aaa0143
Remove unneeded `Promise.resolve`
mbg Sep 10, 2026
0484c3a
Merge remote-tracking branch 'origin/main' into mbg/move-changetool
mbg Sep 10, 2026
File filter

Filter by extension

Filter by extension .json  (7) .mjs  (1) .mts  (3) .yml  (1) All 4 file types selected
Only manifest files
Deleted files Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
35 changes: 4 additions & 31 deletions .github/workflows/pr-checks.yml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
cache: "npm"

- name: Install dependencies
run: |
Expand Down Expand Up @@ -77,33 +77,6 @@ jobs:
sarif_file: eslint.sarif
category: eslint

changetool-tests:
name: changetool unit tests
permissions:
contents: read
runs-on: ubuntu-slim
timeout-minutes: 10

concurrency:
cancel-in-progress: ${{ github.event_name == 'pull_request' || false }}
group: pr-checks-changetool-tests-${{ github.ref }}-${{ github.event_name }}

steps:
- name: Checkout repository
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- name: Set up Node.js
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 24
cache: 'npm'

- name: Install dependencies
run: npm ci

- name: Run changetool unit tests
run: npm --workspace changetool test

# These checks do not need to be run as part of the same matrix that we use for the `unit-tests`
# job.
other-checks:
Expand All @@ -126,7 +99,7 @@ jobs:
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
with:
node-version: 24
cache: 'npm'
cache: "npm"

- name: Install dependencies
id: install-deps
Expand Down Expand Up @@ -190,14 +163,14 @@ jobs:
path: ${{ runner.temp }}/repo-size/
if-no-files-found: error

- name: 'Backport: Check out base ref'
- name: "Backport: Check out base ref"
id: checkout-base
if: ${{ startsWith(github.head_ref, 'backport-') }}
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
ref: ${{ github.base_ref }}

- name: 'Backport: Verify Node versions unchanged'
- name: "Backport: Verify Node versions unchanged"
if: steps.checkout-base.outcome == 'success'
env:
HEAD_VERSION: ${{ steps.head-version.outputs.node_version }}
Expand Down
16 changes: 1 addition & 15 deletions eslint.config.mjs
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ export default [
},
},
{
files: ["pr-checks/**/*.ts"],
files: ["pr-checks/**/*.ts", "pr-checks/**/*.mts"],

languageOptions: {
parserOptions: {
Expand Down Expand Up @@ -209,18 +209,4 @@ export default [
],
},
},
{
files: ["scripts/changetool/**/*.ts"],

languageOptions: {
parserOptions: {
project: "./scripts/changetool/tsconfig.json",
},
},

rules: {
"no-console": "off",
"import/extensions": "off",
},
},
];
Loading
Loading
Back | FazBrowse Home | New Git URL