| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d9f196d4-6d15-44ca-bd01-cd022d57d2cc
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d9f196d4-6d15-44ca-bd01-cd022d57d2cc
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d9f196d4-6d15-44ca-bd01-cd022d57d2cc
There was a problem hiding this comment.
Warning
The broader default rollout removes the feature-flag override, leaving release-based rollback and warranting human sign-off.
1 open finding What changed in this PRMakes per-language CodeQL bundles the default for eligible single-language analyses on GitHub-hosted runners on GitHub.com.
Changes:
| File | Description |
|---|---|
| src/setup-codeql.ts | Uses synchronous bundle selection. |
| src/setup-codeql.test.ts | Updates default-selection and fallback tests. |
| src/per-language-bundles.ts | Removes feature-flag gating. |
| src/per-language-bundles.test.ts | Removes flag-dependent eligibility tests. |
| src/feature-flags.ts | Removes the rollout flag and environment override. |
| pr-checks/checks/per-language-bundle-validation.yml | Validates linked bundles after clearing the toolcache. |
| pr-checks/checks/export-file-baseline-information.yml | Uses custom configuration to select the combined bundle. |
🧠 Review effort: Max
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
There was a problem hiding this comment.
Just a few minor points, otherwise this looks good I think.
Sorry, something went wrong.
| logger, | ||
| }: ActionState<["Logger", "ReadOnlyEnv", "FeatureFlags"]>, | ||
| export function getPerLanguageBundleLanguage( | ||
| { env, logger }: ActionState<["Logger", "ReadOnlyEnv"]>, |
There was a problem hiding this comment.
Minor: To avoid diff noise when the required state features of a function change (since I have seen that in a few recent PRs), here's what I generally do / how I intended this to be used:
Sorry, something went wrong.
…per-language-bundles Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
| Back | FazBrowse Home | New Git URL |
Per-language CodeQL bundles are already supported and have been rolled out behind per_language_bundles_v2. This change removes that rollout feature and makes automatic selection the default for eligible single-language analyses on GitHub-hosted runners on GitHub.com.
The baseline-information check uses a no-op custom configuration to continue validating the combined bundle.
Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
Products:
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist