Augment where we insert baseline lines of code - #624
Merged
edoardopirovano merged 2 commits intoJul 21, 2021
Merged
edoardopirovano merged 2 commits into
edoardopirovano merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Somehow one of the Node packages in main had managed to get out of sync with that the lockfile specified. This should be impossible due to the PR checks so I'm not quite sure how that happened. Anyway, I've pushed an additional commit to this PR to address that (probably no need to do it in a separate PR?). |
Sorry, something went wrong.
rneatherway
approved these changes
Jul 21, 2021
Copy link
Copy Markdown
Contributor
|
I've confirmed that this change gives the expected result in a test repository: "metricResults": [
{
"rule": {
"toolComponent": {
"index": 22
},
"index": 70,
"id": "js/summary/lines-of-code"
},
"ruleId": "js/summary/lines-of-code",
"baseline": 3,
"value": 3
},
{
"rule": {
"toolComponent": {
"index": 22
},
"index": 71,
"id": "js/summary/lines-of-user-code"
},
"ruleId": "js/summary/lines-of-user-code",
"baseline": 3,
"value": 3
}
], |
Sorry, something went wrong.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the code that injects the baseline LOC count into the SARIF results to also inject it into any metricResult that references a rule which has the lines-of-code tag. This is the location that newer versions of Code Scanning will expect to find the LOC count. The old style (injecting into the metricResult with suffix /summary/lines-of-code) is also retained for backwards compatibility, but we should be able to remove this eventually.
I don't think we need a changelog entry as this change shouldn't really affect any users (unless they are manually uploading the SARIF to a non-Code Scanning endpoint, which I'm not sure is a scenario we support).
Merge / deployment checklist