Remove old baseline LoC injection - #715
Merged
aeisenberg merged 4 commits intoSep 1, 2021
Merged
aeisenberg merged 4 commits into
aeisenberg merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aeisenberg
reviewed
Aug 26, 2021
aeisenberg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good to me, but perhaps a quick look by @robertbrignull or @rneatherway would be good.
Sorry, something went wrong.
rneatherway
approved these changes
Aug 31, 2021
aeisenberg
enabled auto-merge
September 1, 2021 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the old-style injection of baseline lines of code that was needed during a transition period while Code Scanning was updated to look for the lines of code in the new location (which was added in #624). The old way was never shipped in GHES, so we do not need to worry about compatibility with old versions and can remove this now.
cc. @rneatherway
Merge / deployment checklist