Hmm, as much as I'd like getting rid of the old code, perhaps we shouldn't suddenly enable the new way to do things in production the moment the new CLI release timed to coincide with GitHub Universe becomes available ...

I would like the switch to be made separately to a CLI release so any issues are attributed to the correct cause more easily.

Both sensible points. How about we merge this after the next CLI release and do an Action release shortly after (and after GitHub Universe)? That way we'll have two versions of the Action using the same CLI but with and without the new style of tracing.

Thanks for the review! Per the discussion above, I will hold off on merging until after GitHub Universe.

Cc @criemen.

Do we now have an integration test for this that tests that unsetting the entire environment doesn't break extraction of C++ or C#?

Do we now have an integration test for this that tests that unsetting the entire environment doesn't break extraction of C++ or C#?

This is a good point. There's a test in semmle-code on the indirect build tracing feature that the Action is using, but it's probably worth having an end-to-end integration test with the Action here. I have added this unsetting to one of our existing integration tests.

Leaving a blocking review until the Go special casing discussed on slack has been resolved.

Thanks. I believe this has now been resolved with no changes needed as we have decided we will not special case Go going forward.

Aargh, looks like something is still broken 😠

Let me investigate what is going on...

Aargh, looks like something is still broken 😠

Let me investigate what is going on...

The root cause of this was https://github.com/github/codeql-coreql-team/issues/1719.

I don't think this needs to block releasing this as things were already broken there. If there's no objections, I'll merge this and do a separate codeql-action release tomorrow per @alexet's suggestion so we can pinpoint any issues that may arise to this PR.