Refuse to run on Windows 11 - #869
Merged
edoardopirovano merged 1 commit intoJan 11, 2022
Merged
edoardopirovano merged 1 commit into
edoardopirovano merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
src/util.ts
Outdated
edoardopirovano
force-pushed
the
edoardo/windows-11-error
branch
from
b509626 to
3b74b38
Compare
January 11, 2022 18:01
Copy link
Copy Markdown
Contributor
|
I just remembered the suggestion I made on the corresponding CLI PR: non-compiled languages are perfectly fine, and we should avoid blocking them from running on Windows 11. Could we move this check later and error only if there is a compiled language in use? |
Sorry, something went wrong.
edoardopirovano
force-pushed
the
edoardo/windows-11-error
branch
3 times, most recently
from
2c0998f to
8361428
Compare
January 11, 2022 18:22
Copy link
Copy Markdown
Contributor
Author
|
Good point, done @adityasharad. Sample error on the latest commit: https://github.com/github/codeql-action/runs/4779658824 |
Sorry, something went wrong.
adityasharad
approved these changes
Jan 11, 2022
Comment thread
src/init-action.ts
Outdated
edoardopirovano
force-pushed
the
edoardo/windows-11-error
branch
from
8361428 to
d2a0fc8
Compare
January 11, 2022 18:34
edoardopirovano
added a commit
that referenced
this pull request
Feb 24, 2022
Revert "Merge pull request #869 from github/edoardo/windows-11-error"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refuse to run on Windows 11 and Windows Server 2022 which are currently unsupported. Sample failing run (obtained by modifying one of our CI checks to run on windows-2022): https://github.com/github/codeql-action/runs/4779298247
Merge / deployment checklist