FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "Merge pull request #869 from github/edoardo/windows-11-error" by edoardopirovano · Pull Request #948 · github/codeql-action · GitHub

/ codeql-action Public

Revert "Merge pull request #869 from github/edoardo/windows-11-error" - #948

Merged
edoardopirovano merged 1 commit into
mainfrom
edoardo/revert-windows-11
Feb 24, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Revert "Merge pull request #869 from github/edoardo/windows-11-error"#948
edoardopirovano merged 1 commit into
mainfrom
edoardo/revert-windows-11

Conversation

edoardopirovano commented Feb 24, 2022

Copy link
Copy Markdown
Contributor

This reverts commit faa9ba7, reversing changes made to 71112ab.

The last few versions of the CodeQL CLI have emitted errors about tracing incompatibility with Windows 11, so there is no need for the Action to continue to emit these. In addition, the CodeQL CLI will soon be compatible with Windows 11, so if we still had the error here in place when that happens we would be stopping users from using CodeQL on Windows 11 for no good reason.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

edoardopirovano requested a review from a team as a code owner February 24, 2022 11:33
criemen approved these changes Feb 24, 2022
View reviewed changes

criemen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM from my side (but I'm not an actions reviewer, so maybe get a review from them, too)

henrymercer reviewed Feb 24, 2022
View reviewed changes

henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should we continue to raise errors for users using old versions of CodeQL with build tracing that's incompatible with Windows 11?

criemen commented Feb 24, 2022

Copy link
Copy Markdown
Contributor

I thought about this, but I don't think it's necessary:
These users would have to pin an old version of the CLI in their workflow, but use the codeql-action from v1/main. I think that's sufficiently uncommon to not keep this code around, as it's pure tech debt for us.
Especially as the code is relying on a hand-written list of which languages are traced and which are not, without querying the CLI.

edoardopirovano commented Feb 24, 2022

Copy link
Copy Markdown
Contributor Author

I'm inclined to agree. We already have so many version flags in the Action, if we can avoid adding another one that seems preferable.

henrymercer commented Feb 24, 2022

Copy link
Copy Markdown
Contributor

Makes sense 👍

edoardopirovano merged commit 438f654 into main Feb 24, 2022
edoardopirovano deleted the edoardo/revert-windows-11 branch February 24, 2022 14:36
github-actions Bot mentioned this pull request Mar 7, 2022
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

criemen criemen approved these changes
henrymercer henrymercer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL