Repository navigation
install: report unsupported operating systems - #4761
Closed
1fanwang wants to merge 1 commit into
Closed
1fanwang wants to merge 1 commit into
1fanwang wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused detection change correctly handles FreeBSD while preserving supported platform behavior.
Pull request overviewUpdates OS detection so unsupported systems no longer fall through to Windows installation logic.
Changes:
- Recognizes Cygwin, MinGW, and MSYS as Windows.
- Reports unknown platforms using their uname -s value.
| File | Description |
|---|---|
| install.sh | Adds explicit Windows matching and unsupported-OS handling. |
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Superseded by #4762, which landed the same detection change. Closing. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On FreeBSD, install.sh reports Windows detected but winget not found because every operating system other than macOS and Linux falls into the Windows branch. Copilot CLI does not publish a FreeBSD binary, so the installer should report the platform as unsupported.
What changed
The installer now treats Cygwin, MinGW, and MSYS as Windows. Other unknown systems fail with their actual uname -s value.
References
#3710
Testing
bash -n install.sh and git diff --check pass.