Repository navigation
install: report unsupported operating systems - #4762
devm33 merged 2 commits into
Conversation
Sorry, something went wrong.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new unsupported-OS error path re-runs uname -s despite set -e, which can cause an early exit before printing the intended error and is avoidable by caching the initial uname result.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 1
| Severity | Finding |
|---|---|
| install.sh — uname -s is executed twice: once to select the platform and again in the unsupported-OS error… |
This PR updates the install.sh platform detection logic so that non-macOS/Linux systems no longer default to the Windows install path, and instead report the actual uname -s value as unsupported.
Changes:
- Detect Windows-like environments explicitly via CYGWIN*, MINGW*, and MSYS*.
- Treat all other uname -s values as unsupported and exit with an error message that includes the OS string.
| File | Description |
|---|---|
| install.sh | Refines OS detection to avoid misclassifying BSDs as Windows and reports unsupported platforms explicitly. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Why
On FreeBSD, install.sh reports Windows detected but winget not found because every operating system other than macOS and Linux falls into the Windows branch. Copilot CLI does not publish a FreeBSD binary, so the installer should report the platform as unsupported.
What changed
Fixes #3710.
Testing