FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

OboeTester: Add package name and attribution tag by robertwu1 · Pull Request #2206 · google/oboe · GitHub

/ oboe Public

OboeTester: Add package name and attribution tag - #2206

Merged
robertwu1 merged 4 commits into
mainfrom
robertwu/oboetesterpackagename
May 7, 2025
ConversationCommits (4)ChecksFiles changed
Merged

OboeTester: Add package name and attribution tag#2206
robertwu1 merged 4 commits into
mainfrom
robertwu/oboetesterpackagename

Conversation

robertwu1 commented Apr 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR adds package names and attribution tags to OboeTester. These should be declared for audio streams or there may be permission issues with microphone permissions.

robertwu1 requested review from atneya and flamme April 29, 2025 22:31
philburk reviewed Apr 30, 2025
View reviewed changes
Comment thread apps/OboeTester/app/src/main/cpp/jni-bridge.cpp Outdated
Comment thread apps/OboeTester/app/src/main/cpp/jni-bridge.cpp Outdated
Comment thread apps/OboeTester/app/src/main/java/com/mobileer/oboetester/AudioStreamTester.java Outdated
flamme reviewed Apr 30, 2025
View reviewed changes
Comment thread apps/OboeTester/app/build.gradle Outdated
Comment thread apps/OboeTester/app/src/main/java/com/mobileer/oboetester/OboeAudioStream.java Outdated
Comment thread apps/OboeTester/app/src/main/java/com/mobileer/oboetester/AudioStreamTester.java Outdated
Comment thread apps/OboeTester/app/src/main/cpp/jni-bridge.cpp Outdated

flamme commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator

BTW, from a test purpose, do we want to allow to random set package name and attribution tag when opening streams?

robertwu1 commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator Author

BTW, from a test purpose, do we want to allow to random set package name and attribution tag when opening streams?

We can but tbh it'll cluster the UI as we almost never use this. I added an example in the unit tests

flamme commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator

BTW, from a test purpose, do we want to allow to random set package name and attribution tag when opening streams?

We can but tbh it'll cluster the UI as we almost never use this. I added an example in the unit tests

I was thinking it would be handy to test some permission issues.

robertwu1 merged commit 7a2a258 into main May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

flamme flamme approved these changes
atneya Awaiting requested review from atneya
+1 more reviewer
philburk philburk left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL