FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

OboeTester: Add package name and attribution tag by robertwu1 · Pull Request #2206 · google/oboe · GitHub

/ oboe Public

OboeTester: Add package name and attribution tag #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertwu1 merged 4 commits into from
May 7, 2025
Conversation 12 Commits 4 Checks 0 Files changed
Merged

OboeTester: Add package name and attribution tag #2206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ba1c23
OboeTester: Add package name and attribution tag
robertwu1 Apr 29, 2025
892aef7
address comments
robertwu1 Apr 30, 2025
305cb88
query actual attribution tag
robertwu1 May 2, 2025
a8e371f
add dialog options
robertwu1 May 2, 2025
File filter

Filter by extension

Filter by extension .cpp  (3) .h  (3) .java  (3) .xml  (3) All 4 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
7 changes: 6 additions & 1 deletion apps/OboeTester/app/src/main/AndroidManifest.xml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.mobileer.oboetester">
<attribution
android:tag="AudioTag"
android:label="@string/audio_attribution_label" />

<uses-feature
android:name="android.hardware.microphone"
android:required="false" />
Expand Down
6 changes: 5 additions & 1 deletion apps/OboeTester/app/src/main/cpp/NativeAudioContext.cpp
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,9 @@ int ActivityContext::open(jint nativeApi,
jint rateConversionQuality,
jboolean isMMap,
jboolean isInput,
jint spatializationBehavior) {
jint spatializationBehavior,
const char *packageName,
const char *attributionTag) {
oboe::AudioApi audioApi = oboe::AudioApi::Unspecified;
switch (nativeApi) {
case NATIVE_MODE_UNSPECIFIED:
Expand Down Expand Up @@ -211,6 +213,8 @@ int ActivityContext::open(jint nativeApi,
->setFormatConversionAllowed(formatConversionAllowed)
->setSampleRateConversionQuality((oboe::SampleRateConversionQuality) rateConversionQuality)
->setSpatializationBehavior((oboe::SpatializationBehavior) spatializationBehavior)
->setPackageName(packageName)
->setAttributionTag(attributionTag)
;
if (channelMask != (jint) oboe::ChannelMask::Unspecified) {
// Set channel mask when it is specified.
Expand Down
6 changes: 5 additions & 1 deletion apps/OboeTester/app/src/main/cpp/NativeAudioContext.h
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ class ActivityContext {
* @param isMMap
* @param isInput
* @param spatializationBehavior
* @param packageName
* @param attributionTag
* @return stream ID
*/
int open(jint nativeApi,
Expand All @@ -131,7 +133,9 @@ class ActivityContext {
jint rateConversionQuality,
jboolean isMMap,
jboolean isInput,
jint spatializationBehavior);
jint spatializationBehavior,
const char *packageName,
const char *attributionTag);

oboe::Result release();

Expand Down
76 changes: 55 additions & 21 deletions apps/OboeTester/app/src/main/cpp/jni-bridge.cpp
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ Java_com_mobileer_oboetester_OboeAudioStream_openNative(JNIEnv *env, jobject,
jint rateConversionQuality,
jboolean isMMap,
jboolean isInput,
jint spatializationBehavior);
jint spatializationBehavior,
jstring packageName,
jstring attributionTag);
JNIEXPORT void JNICALL
Java_com_mobileer_oboetester_OboeAudioStream_close(JNIEnv *env, jobject, jint);

Expand Down Expand Up @@ -160,28 +162,40 @@ Java_com_mobileer_oboetester_OboeAudioStream_openNative(
jint rateConversionQuality,
jboolean isMMap,
jboolean isInput,
jint spatializationBehavior) {
jint spatializationBehavior,
jstring packageName,
jstring attributionTag) {
LOGD("OboeAudioStream_openNative: sampleRate = %d", sampleRate);

return (jint) engine.getCurrentActivity()->open(nativeApi,
sampleRate,
channelCount,
channelMask,
format,
sharingMode,
performanceMode,
inputPreset,
usage,
contentType,
bufferCapacityInFrames,
deviceId,
sessionId,
channelConversionAllowed,
formatConversionAllowed,
rateConversionQuality,
isMMap,
isInput,
spatializationBehavior);
const char *packageNameStr = env->GetStringUTFChars(packageName, nullptr);
const char *attributionTagStr = env->GetStringUTFChars(attributionTag, nullptr);

int result = engine.getCurrentActivity()->open(nativeApi,
sampleRate,
channelCount,
channelMask,
format,
sharingMode,
performanceMode,
inputPreset,
usage,
contentType,
bufferCapacityInFrames,
deviceId,
sessionId,
channelConversionAllowed,
formatConversionAllowed,
rateConversionQuality,
isMMap,
isInput,
spatializationBehavior,
packageNameStr,
attributionTagStr);

env->ReleaseStringUTFChars(packageName, packageNameStr);
env->ReleaseStringUTFChars(attributionTag, attributionTagStr);

return (jint) result;
}

JNIEXPORT jint JNICALL
Expand Down Expand Up @@ -504,6 +518,26 @@ Java_com_mobileer_oboetester_OboeAudioStream_getSessionId(
return result;
}

JNIEXPORT jstring JNICALL
Java_com_mobileer_oboetester_OboeAudioStream_getPackageName(
JNIEnv *env, jobject, jint streamIndex) {
std::shared_ptr<oboe::AudioStream> oboeStream = engine.getCurrentActivity()->getStream(streamIndex);
if (oboeStream != nullptr) {
return env->NewStringUTF(oboeStream->getPackageName().c_str());
}
return env->NewStringUTF("");
}

JNIEXPORT jstring JNICALL
Java_com_mobileer_oboetester_OboeAudioStream_getAttributionTag(
JNIEnv *env, jobject, jint streamIndex) {
std::shared_ptr<oboe::AudioStream> oboeStream = engine.getCurrentActivity()->getStream(streamIndex);
if (oboeStream != nullptr) {
return env->NewStringUTF(oboeStream->getAttributionTag().c_str());
}
return env->NewStringUTF("");
}

JNIEXPORT jlong JNICALL
Java_com_mobileer_oboetester_OboeAudioStream_getFramesWritten(
JNIEnv *env, jobject, jint streamIndex) {
Expand Down
Loading
Back | FazBrowse Home | New Git URL