FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

PyMJCF nested include tags relative to base model by guyazran · Pull Request #417 · google-deepmind/dm_control · GitHub

PyMJCF nested include tags relative to base model - #417

Open
guyazran wants to merge 1 commit into
google-deepmind:mainfrom
guyazran:mjcf_nested_includes
Open

PyMJCF nested include tags relative to base model#417
guyazran wants to merge 1 commit into
google-deepmind:mainfrom
guyazran:mjcf_nested_includes

Conversation

guyazran commented Aug 3, 2023
edited
Loading

Copy link
Copy Markdown

Addresses #418

guyazran force-pushed the mjcf_nested_includes branch from 111b1d2 to 02986a8 Compare August 5, 2023 20:06
guyazran changed the title PyMJCF recursive include tags relative to base model PyMJCF nested include tags relative to base model Aug 5, 2023

jonzamora commented May 26, 2024
edited
Loading

Copy link
Copy Markdown

Hi @guyazran , did you happen to test this out before making your Pull Request here?

e.g. on the example you provided here: #418

I am also interested in composing XML files with PyMJCF which support nested include tags, and i'm hoping to revive this issue so things can be resolved for us and others.

guyazran commented May 28, 2024
edited
Loading

Copy link
Copy Markdown
Author

Hi @jonzamora. Thanks for reviving this PR. It will make running with nested include tags much smoother.

I sent this PR in a long time ago, but I can definitely say that at the time of creating the PR and when I wrote "addresses #418" the example scene in that issue ran smoothly.

However, this might be a pointless effort because in another issue the creators said that they are working on a different solution #407. perhaps you should ping there and see how the alternative solution is working

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL