Reshape arrays rather than setting shape on them. - #548
Open
shubhxho wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
NumPy 2.5 deprecated assigning to ndarray.shape. Every named index built from a list or array of names went through it, so ordinary indexing raised a DeprecationWarning. reshape does the same thing here - the arrays are freshly built and contiguous. Fixes google-deepmind#540. Signed-off-by: Shubh <shubh@shubhxho.com>
Copy link
Copy Markdown
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #540.
Problem
NumPy 2.5 deprecated assigning to ndarray.shape (release note, numpy#29536).
Axis.convert_key_item uses it on every named index built from a list or array of names, so ordinary named indexing emits a DeprecationWarning under NumPy >= 2.5. Two test helpers do the same.
With -W error::DeprecationWarning on NumPy 2.5.2 before the change:
Fix
Use reshape instead. The semantics are the same at all three sites: the arrays are freshly built by np.array/np.arange and contiguous, so no copy is involved and no caller observes a difference.
Testing
The one unrelated failure on my machine, MujocoEngineTest::testRenderFlagOverridesAreNotPersistent, fails identically without this change (headless GL).