This repository was archived by the owner on May 12, 2026. It is now read-only.
fix: use orginal url as audience for self signed jwt if scheme or host is null - #642
Merged
arithmetic1728 merged 4 commits intoApr 27, 2021
Merged
fix: use orginal url as audience for self signed jwt if scheme or host is null#642arithmetic1728 merged 4 commits into
arithmetic1728 merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
=========================================
Coverage 83.59% 83.59%
- Complexity 604 606 +2
=========================================
Files 42 42
Lines 2712 2712
Branches 289 289
=========================================
Hits 2267 2267
Misses 303 303
Partials 142 142
Continue to review full report at Codecov.
|
Sorry, something went wrong.
chingor13
reviewed
Apr 26, 2021
chingor13
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Please add more context to the PR and to the commit message that will be created for the changelog rather as to what's actually being fixed.
Also, please get Silvano's stamp on this fix as I'm not sure what the expected behavior is supposed to be.
Sorry, something went wrong.
silvolu
approved these changes
Apr 27, 2021
Neenu1995
approved these changes
Apr 27, 2021
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
May 20, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [0.26.0](https://www.github.com/googleapis/google-auth-library-java/compare/v0.25.5...v0.26.0) (2021-05-20) ### Features * add `gcf-owl-bot[bot]` to `ignoreAuthors` ([#674](https://www.github.com/googleapis/google-auth-library-java/issues/674)) ([359b20f](https://www.github.com/googleapis/google-auth-library-java/commit/359b20f24f88e09b6b104c61ca63a1b604ea64d2)) * added getter for credentials object in HttpCredentialsAdapter ([#658](https://www.github.com/googleapis/google-auth-library-java/issues/658)) ([5a946ea](https://www.github.com/googleapis/google-auth-library-java/commit/5a946ea5e0d974611f2205f468236db4b931e486)) * enable pre-emptive async oauth token refreshes ([#646](https://www.github.com/googleapis/google-auth-library-java/issues/646)) ([e3f4c7e](https://www.github.com/googleapis/google-auth-library-java/commit/e3f4c7eac0417705553ef8259599ec29fc8ad9b4)) * Returning an issuer claim on request errors ([#656](https://www.github.com/googleapis/google-auth-library-java/issues/656)) ([95d70ae](https://www.github.com/googleapis/google-auth-library-java/commit/95d70ae0f5f4c985455f913ddef14ebe75500656)) ### Bug Fixes * use orginal url as audience for self signed jwt if scheme or host is null ([#642](https://www.github.com/googleapis/google-auth-library-java/issues/642)) ([b4e6f1a](https://www.github.com/googleapis/google-auth-library-java/commit/b4e6f1a0bd17dd31edc85ed4879cea75857fd747)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getUriForSelfSignedJWT(URI uri) is used to convert "https://compute.googleapis.com/compute/v1/projects/" to "https://compute.googleapis.com/", so if the uri's scheme or host is null (for instance when user provided an uri like compute.googleapis.com), it should return the original uri.