FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: added getter for credentials object in HttpCredentialsAdapter by shubha-rajan · Pull Request #658 · googleapis/google-auth-library-java · GitHub

This repository was archived by the owner on May 12, 2026. It is now read-only.
/ google-auth-library-java Public archive

feat: added getter for credentials object in HttpCredentialsAdapter - #658

Merged
shubha-rajan merged 4 commits into
googleapis:masterfrom
shubha-rajan:credentials-getter
May 13, 2021
ConversationCommits (4)ChecksFiles changed
Merged

feat: added getter for credentials object in HttpCredentialsAdapter#658
shubha-rajan merged 4 commits into
googleapis:masterfrom
shubha-rajan:credentials-getter

Conversation

shubha-rajan commented May 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #659☕️

google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label May 12, 2021

codecov Bot commented May 12, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #658 (bfc1e86) into master (292e81a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head bfc1e86 differs from pull request most recent head 30f2371. Consider uploading reports for the commit 30f2371 to get more accurate results

@@            Coverage Diff            @@
##             master     #658   +/-   ##
=========================================
  Coverage     83.59%   83.59%           
- Complexity      606      607    +1     
=========================================
  Files            42       42           
  Lines          2712     2713    +1     
  Branches        289      289           
=========================================
+ Hits           2267     2268    +1     
  Misses          303      303           
  Partials        142      142
Impacted Files Coverage Δ Complexity Δ
...a/com/google/auth/http/HttpCredentialsAdapter.java 68.18% <100.00%> (+0.73%) 9.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc13ac6...30f2371. Read the comment docs.

shubha-rajan marked this pull request as ready for review May 12, 2021 17:47
shubha-rajan requested a review from a team May 12, 2021 17:47
shubha-rajan mentioned this pull request May 12, 2021
Merged
3 tasks
shubha-rajan merged commit 5a946ea into googleapis:master May 13, 2021
gcf-merge-on-green Bot pushed a commit that referenced this pull request May 20, 2021
chore: release 0.26.0 (#644)
db2f85a 
🤖 I have created a release \*beep\* \*boop\*
---
## [0.26.0](https://www.github.com/googleapis/google-auth-library-java/compare/v0.25.5...v0.26.0) (2021-05-20)


### Features

* add `gcf-owl-bot[bot]` to `ignoreAuthors` ([#674](https://www.github.com/googleapis/google-auth-library-java/issues/674)) ([359b20f](https://www.github.com/googleapis/google-auth-library-java/commit/359b20f24f88e09b6b104c61ca63a1b604ea64d2))
* added getter for credentials object in HttpCredentialsAdapter ([#658](https://www.github.com/googleapis/google-auth-library-java/issues/658)) ([5a946ea](https://www.github.com/googleapis/google-auth-library-java/commit/5a946ea5e0d974611f2205f468236db4b931e486))
* enable pre-emptive async oauth token refreshes ([#646](https://www.github.com/googleapis/google-auth-library-java/issues/646)) ([e3f4c7e](https://www.github.com/googleapis/google-auth-library-java/commit/e3f4c7eac0417705553ef8259599ec29fc8ad9b4))
* Returning an issuer claim on request errors ([#656](https://www.github.com/googleapis/google-auth-library-java/issues/656)) ([95d70ae](https://www.github.com/googleapis/google-auth-library-java/commit/95d70ae0f5f4c985455f913ddef14ebe75500656))


### Bug Fixes

* use orginal url as audience for self signed jwt if scheme or host is null ([#642](https://www.github.com/googleapis/google-auth-library-java/issues/642)) ([b4e6f1a](https://www.github.com/googleapis/google-auth-library-java/commit/b4e6f1a0bd17dd31edc85ed4879cea75857fd747))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
shubha-rajan mentioned this pull request Sep 15, 2021
Closed
release-please Bot mentioned this pull request Jan 4, 2022
Closed
release-please Bot mentioned this pull request Aug 11, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
Neenu1995 Neenu1995 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add getter for credentials object in HttpCredentialsAdapter

2 participants

Back | FazBrowse Home | New Git URL