Move future files out of internal/. - #1450
Merged
coryan merged 1 commit intoNov 15, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The public headers for `future<T>` should be in google/cloud/ so they can be picked up by the Doxygen scripts. This fixes googleapis#1345.
coryan
force-pushed
the
futures-from-the-future-pr17
branch
from
cba2409 to
cc753c8
Compare
November 14, 2018 23:30
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #1450 +/- ##
=======================================
Coverage 94.45% 94.45%
=======================================
Files 262 262
Lines 14417 14417
=======================================
Hits 13618 13618
Misses 799 799
Continue to review full report at Codecov.
|
Sorry, something went wrong.
dopiera
approved these changes
Nov 15, 2018
dopiera
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @deepankarsharma)
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public headers for future<T> should be in google/cloud/ so they
can be picked up by the Doxygen scripts. This fixes #1345.
This change is